keep subscriptions up to date when accessories are replaced #172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
but the connection is _not_ torn down also add the ability to modify accessories in a batch without having to regenerate all AIDs and IIDs (and other temporary data structures) at each intermediate step. You must use this mechanism if you plan on replacing an existing accessory with an equivalent one, but want to keep subscriptions intact.
yfre
reviewed
Oct 26, 2022
yfre
requested changes
Nov 2, 2022
| } | ||
| reverse.get(connection).add(characteristic); | ||
| LOGGER.trace( | ||
| "Added subscription to " + characteristic.getClass() + " for " + connection.hashCode()); | ||
| LOGGER.debug( |
There was a problem hiding this comment.
the logging levels in Java-HAP are aligned with openHAB logging levels.
https://www.openhab.org/docs/developer/guidelines.html#f-logging
i.e. "debug" is used for unexpected expected behavior.
trace for all detailed logging.
please revert it back to debug so that it is consistent within Java-HAP and as bonus also with openHAB
please check other LOGGER.debug in this PR as well
|
ping @yfre : I believe I've addressed all of your comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
but the connection is not torn down
also add the ability to modify accessories in a batch without having to regenerate all AIDs and IIDs (and other temporary data structures) at each intermediate step. You must use this mechanism if you plan on replacing an existing accessory with an equivalent one, but want to keep subscriptions intact.